Skip to content

misc: test union member name same as union #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 14, 2025
Merged

misc: test union member name same as union #1241

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
30002d0
misc: test union with member that has the same name
0marperez Feb 13, 2025
bd9ceb4
misc: move model to unit test
0marperez Feb 13, 2025
6da3219
misc: add GH PR link
0marperez Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions tests/compile/src/test/kotlin/software/amazon/smithy/kotlin/codegen/SmithySdkTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,45 @@ class SmithySdkTest {

assertEquals(KotlinCompilation.ExitCode.OK, compilationResult.exitCode, compileOutputStream.toString())
}

// https://github.com/smithy-lang/smithy-kotlin/issues/1129
@Test
fun `it compiles models with unions with members that have the same name as the union`() {
Comment on lines +229 to +230
Copy link
Contributor

@lauzadis lauzadis Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs: add a comment with the original GitHub issue that inspired this test case

val model = """
namespace aws.sdk.kotlin.test

use aws.protocols#awsJson1_0
use smithy.rules#operationContextParams
use smithy.rules#endpointRuleSet
use aws.api#service

@awsJson1_0
@service(sdkId: "UnionOperationTest")
service TestService {
operations: [UnionOperation],
version: "1"
}

operation UnionOperation {
input: UnionOperationRequest
}

structure UnionOperationRequest {
Union: Foo
}

union Foo {
foo: Boolean
}

""".asSmithy()

val compileOutputStream = ByteArrayOutputStream()
val compilationResult = compileSdkAndTest(model = model, outputSink = compileOutputStream, emitSourcesToTmp = Debug.emitSourcesToTemp)
compileOutputStream.flush()

assertEquals(KotlinCompilation.ExitCode.OK, compilationResult.exitCode, compileOutputStream.toString())
}
}

/**
Expand Down
Loading