Skip to content

misc: add lineSeparator to Filesystem #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lauzadis merged 5 commits into from
Apr 14, 2025
Merged

misc: add lineSeparator to Filesystem #1267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6f71c9f
Add `lineSeparator` to Filesystem
lauzadis Apr 10, 2025
026c4ca
Add TODO implementation on Native
lauzadis Apr 10, 2025
270bdd3
Remove `lineSeparator` from `Filesystem`, define as a public extensio…
lauzadis Apr 14, 2025
84c842d
Revert apiDump
lauzadis Apr 14, 2025
0a9302f
apiDump
lauzadis Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions runtime/runtime-core/api/runtime-core.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2392,6 +2392,10 @@ public final class aws/smithy/kotlin/runtime/util/OsFamily : java/lang/Enum {
public abstract interface class aws/smithy/kotlin/runtime/util/PlatformEnvironProvider : aws/smithy/kotlin/runtime/util/EnvironmentProvider, aws/smithy/kotlin/runtime/util/PropertyProvider {
}

public final class aws/smithy/kotlin/runtime/util/PlatformKt {
public static final fun getLineSeparator (Laws/smithy/kotlin/runtime/util/OperatingSystem;)Ljava/lang/String;
}

public abstract interface class aws/smithy/kotlin/runtime/util/PlatformProvider : aws/smithy/kotlin/runtime/util/Filesystem, aws/smithy/kotlin/runtime/util/PlatformEnvironProvider {
public static final field Companion Laws/smithy/kotlin/runtime/util/PlatformProvider$Companion;
public abstract fun isAndroid ()Z
Expand Down
9 changes: 9 additions & 0 deletions runtime/runtime-core/common/src/aws/smithy/kotlin/runtime/util/Platform.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,15 @@ internal expect object SystemDefaultProvider : PlatformProvider {

public data class OperatingSystem(val family: OsFamily, val version: String?)

/**
* The string which represents a line separator on this file system. For example, on Windows, this is CRLF.
*/
public val OperatingSystem.lineSeparator: String
get() = when {
family == OsFamily.Windows -> "\r\n"
else -> "\n"
}

public enum class OsFamily {
Linux,
MacOs,
Expand Down
Loading