Skip to content

Conversation

@0marperez
Copy link
Contributor

Issue #

N/A

Description of changes

Shapes with members named "result" would cause naming collisions due to the local variable also named "result" in the hashcode function. If we access the result member using this we're able to remove ambiguity caused by the naming collision.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@0marperez 0marperez requested a review from a team as a code owner September 30, 2025 19:05
@github-actions
Copy link

Affected Artifacts

Changed in size
Artifact Pull Request (bytes) Latest Release (bytes) Delta (bytes) Delta (percentage)
http-test-jvm.jar 62,181 59,427 2,754 4.63%
crt-util-jvm.jar 21,733 21,055 678 3.22%
aws-signing-default-jvm.jar 68,505 66,941 1,564 2.34%
runtime-core-jvm.jar 852,677 835,526 17,151 2.05%
http-client-engine-crt-jvm.jar 54,233 53,980 253 0.47%
aws-signing-crt-jvm.jar 16,114 16,081 33 0.21%
test-suite-jvm.jar 99,844 100,085 -241 -0.24%

@0marperez 0marperez enabled auto-merge (squash) September 30, 2025 19:20
@0marperez 0marperez merged commit d132423 into main Sep 30, 2025
25 checks passed
@0marperez 0marperez deleted the fix-name-clash branch September 30, 2025 19:20
0marperez added a commit that referenced this pull request Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants