Handle empty and incomplete event bytes #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds in explicit handling for both emtpy and incomplete event bytes. If nothing is able to be read from the source, event decoders will return None. If there are bytes there, but they're truncated, then an explicit error is thrown that wraps what would otherwise be a `struct.error`. This is only applied for truncations that would not already be caught by checksum validation.
nateprewitt
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds in explicit handling for both emtpy and incomplete event bytes. If nothing is able to be read from the source, event decoders will return None. If there are bytes there, but they're truncated, then an explicit error is thrown that wraps what would otherwise be a
struct.error. This is only applied for truncations that would not already be caught by checksum validation.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.