Replace pants with uv and simplify development workflow #385
Conversation
| authors = [ | ||
| { name = "Hayden Baker", email = "[email protected]" } | ||
| ] |
There was a problem hiding this comment.
Bold, but not what we want here. iirc this is optional so best to remove it
There was a problem hiding this comment.
Haha, yeah, this was a mistake. UV added this when initializing the projects.
There was a problem hiding this comment.
Do we want to add any other fields from the previous toml files? e.g. license, keywords, classifiers, etc?
There was a problem hiding this comment.
Yeah let's add those, but as a separate PR so that this can get merged
| @@ -1,34 +0,0 @@ | |||
| name: Lint code | |||
There was a problem hiding this comment.
These have been removed, but it's not clear that they've been replaced. Have they?
There was a problem hiding this comment.
The main ci workflow does everything now, this includes linting/typechecking/tests/etc. This has the benefit of only requiring a single action, and only needing to set up the environment once. It runs fairly quickly (~3 minutes, most of which is spent initializing gradle and building java).
There was a problem hiding this comment.
We could separate out building codegen as a separate job within in the same action, but let's see if the action run time becomes an issue first.
There was a problem hiding this comment.
I'm not really concerned about runtime, i'm more concerned about separation of concerns. It's useful to see at a glance what's failing and why without having to dig into some logs. This isn't a blocker though - we can make that change later if we want
haydenbaker
force-pushed
the
haydenbaker/reorg-python
branch
from
f45fdf6 to
fc03d0a
Compare
haydenbaker
force-pushed
the
haydenbaker/reorg-structure
branch
from
71c6fde to
cff5f59
Compare
| b"\x00\x00\x00\x00" # headers length | ||
| b"\x05\xc2\x48\xeb" # prelude crc | ||
| b"\x7D\x98\xc8\xff" # message crc | ||
| b"\x7d\x98\xc8\xff" # message crc |
There was a problem hiding this comment.
Dang, ruff is really this pedantic huh
2 participants
Description of changes:
TODOs:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.