Add initial aws-sdk-signers package #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'll take a look at the new docformatter tomorrow, some of these suggestions are definitely not what we want. We may need to tweak the config. |
JordonPhillips
previously approved these changes
Feb 27, 2025
Contributor
JordonPhillips
left a comment
JordonPhillips
left a comment
There was a problem hiding this comment.
Make sure we've got a task to resolve these shared code issues. The IO stuff is easy enough to extract. Having an HTTP package with just protocols might be a bit weird, but probably reasonable?
| chain.from_iterable( | ||
| fld.as_tuples() | ||
| for fld in request.fields.get_by_type(FieldPosition.HEADER) | ||
| for fld in request.fields |
Contributor
There was a problem hiding this comment.
Why was this change made?
Contributor
Author
There was a problem hiding this comment.
We're not actually adding the FieldPosition correctly for headers so we end up with an empty list here. I have a task to go back and work out what's failing. This was a carry over from the original client POC that I still need to sort out.
nateprewitt
force-pushed
the
initial_signers
branch
from
62730e4 to
8b0ec44
Compare
nateprewitt
force-pushed
the
initial_signers
branch
from
0fd8a21 to
0258cf2
Compare
JordonPhillips
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The PR adds a
aws-sdk-signerspackage with basic SigV4 signing capabilities. This will need to be wired up to our clients in a follow up PR and then added to sign events for the aws-eventstream implementation.The goal is this package can live inside the smithy-python repo long term while also being able to be distributed independently of any of the smithy-* libraries. There is still some work needed to fully decouple typing for that which will be done in a future PR.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.