Generate Regional endpoints #394
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… just renders endpoint_parameter construction
alextwoods
changed the title
nateprewitt
reviewed
Mar 4, 2025
Contributor
nateprewitt
left a comment
nateprewitt
left a comment
There was a problem hiding this comment.
Two minor comments, otherwise looks good!
packages/smithy-aws-core/src/smithy_aws_core/endpoints/standard_regional.py
Outdated
Show resolved
Hide resolved
nateprewitt
previously approved these changes
Mar 4, 2025
JordonPhillips
requested changes
Mar 5, 2025
| endpoint = await config.endpoint_resolver.resolve_endpoint( | ||
| StaticEndpointParams(uri=config.endpoint_uri) | ||
| ) | ||
| context.endpointsGenerator().renderEndpointParameterConstruction(context, writer); |
Contributor
There was a problem hiding this comment.
This is a prime use case for a CodeSection. You would create a section like this called EndpointParamSection or something like that with the necessary context, and then a PythonIntegration would return a CodeInterceptor in its interceptors method.
Then here you'd have something like:
writer.pushState(new EndpointParamsSection(context));
// Default implementation. Interceptors can be blow it away.
writer.write("""
endpoint_parameters = StaticEndpointParams(uri=config.endpoint_uri)
""");
writer.popState();You can then get rid of the EndpointsGenerator entirely.
smithy-python doesn't use sections or interceptors much currently, but it should.
Contributor
Author
There was a problem hiding this comment.
For an implementation of an approach using CodeSections and CodeInterceptor see: #407
Contributor
|
I prefer option 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds a hook for integrations to register an endpoints generator that is responsible for generating client configuration and resolution logic.
Adds an Aws Standard Regional Endpoints generation path that adds region to client config and generates logic to use a simple pattern based regional endpoint resolver.
The generic hook for endpoint generation can be used in the future to implement Endpoints2.0 both generically or in Aws flavors (specifically accounting for AWS builtins / std lib functions).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.