Update traits to allow for dynamically discoverable implementations #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateprewitt
previously approved these changes
Feb 28, 2025
| get_payload_member, | ||
| ) | ||
| from .traits import EVENT_HEADER_TRAIT | ||
| from smithy_core.traits import EventHeaderTrait |
Contributor
There was a problem hiding this comment.
Just for my understanding, is the EventHeaderTrait ever used outside of an Event Stream implementation? Is this just being ported back to consolidate all the traits together or is there another theoretical library we'd use this in?
Contributor
Author
There was a problem hiding this comment.
This is only ever used by event streams, yes. But it could be used if we had an alternative event stream format or something like that. I've kept all the traits in core because so far we're only using traits from Smithy's default set of traits. But we could conceivably split them up too.
This updates traits to use a dynamic registry to allow concrete implementations to be automatically discovered and created when constructing schemas.
JordonPhillips
force-pushed
the
power-traits
branch
from
e48e902 to
a33dcb9
Compare
Contributor
Author
|
had to rebase |
alextwoods
reviewed
Feb 28, 2025
| comfortable to use, providing better typed accessors to data or even relevant | ||
| utility functions. | ||
|
|
||
| Both kinds of traits implement an inherent `Protocol` - they both have the `id` |
nateprewitt
approved these changes
Mar 4, 2025
| def expect_trait(self, t: ShapeID) -> "Trait | DynamicTrait": ... | ||
|
|
||
| def expect_trait(self, t: "type[Trait] | ShapeID") -> "Trait | DynamicTrait": | ||
| """Get a trait based on it's ShapeID or class. |
Contributor
There was a problem hiding this comment.
Suggested change
| """Get a trait based on it's ShapeID or class. | |
| """Get a trait based on its ShapeID or class. |
nateprewitt
added a commit
that referenced
this pull request
Mar 4, 2025
nateprewitt
added a commit
that referenced
this pull request
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the design for traits from being simple bags of loosely typed data. Now traits may instead have concrete implementations that are discoverable dynamically simply by implementing the relevant subclass.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.