Add HTTP Binding serializers and deserializers #400
Conversation
|
I hate that you can't convert to draft after the fact |
|
You can, the UX is just a little out of the way. Under reviewers press this: |
JordonPhillips
force-pushed
the
http-schema
branch
6 times, most recently
from
02c58af to
1b1df12
Compare
JordonPhillips
changed the title
This adds type guard functions for StreamingBlob and BytesReader since both are difficult to distinguish due to runtime_checkable not checking async.
Co-authored-by: Nate Prewitt <[email protected]>
JordonPhillips
force-pushed
the
http-schema
branch
from
74f83a9 to
ccae6a8
Compare
| return self.document_value # type: ignore | ||
|
|
||
|
|
||
| # TODO: Get all this moved over to the http package |
There was a problem hiding this comment.
Does it need to be? I don't think we need to put traits in their "respective" packages
There was a problem hiding this comment.
I'd tend to agree with this, I think the other PR we moved everything into the centralized location. I like that unless we have a technical limitation of keeping them together. Is the concern that we may include traits that aren't needed if the smithy-http package isn't present, or are we hitting typing problems?
There was a problem hiding this comment.
It's more about fighting against package size inflation, though practically for HTTP it's not much of an issue.
|
Looks like you need to run the gradle build one more time before committing, |
This PR doesn't touch |
3 participants
This adds ShapeSerializers and ShapeDeserializers for HTTP bindings. It's a draft that still needs tests but it should work, more or less.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.