Fix for optional dependencies of SymbolDependencies. #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Addresses comment from: #409 (comment)
The issue is that optional dependencies are stored as typed properties on the symbol dependencies and those properties are not merged by smithy's gatherDependencies method. We're adding the smithy_http dependency hundreds of times through out the code, but only once with the optionalDependencies specified.
This PR sets awscrt and aiohttp as optional dependencies on the smithy_http SymbolDependency (undooing changes from #409) and uses a custom
gatherDependencieswith a custom merge function that merges theOPTIONAL_DEPENDENCIESproperty.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.