De-duplicate Config (Fix duplicate Region) #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Previously we collected
ConfigPropertyin a list, however, multiple integrations/runtime plugins may need to independently register and depend on the same configuration properties - an example of this is sigv4 auth and regional endpoints - they both depend on theregionconfig and could potentially be used independently of each other, so should both register the config properties they need without trying to inspect or understand what other integrations/runtime plugins are being used.This PR changes the data structure used to collect ConfigProperties during generation from a
Listto aTreeSetwhich uses the propertiesnameto de-dupe it.Currently, the first registered config value with a specific name will be preserved, which does not allow runtime plugins to override base config properties (eg: with this ordering, its not possible for a runtime plugin to override the the
http_client).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.