Skip to content

Add host header when unset to crt requests #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2025
Merged

Add host header when unset to crt requests #427

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
febae70
Add Host header in CRT client if unset
alextwoods Mar 11, 2025
64cd6b4
Set the host header if not set in CRT HTTP client.
alextwoods Mar 11, 2025
920c362
Add test
alextwoods Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/smithy-http/src/smithy_http/aio/crt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,8 +292,14 @@ async def _marshal_request(
"""Create :py:class:`awscrt.http.HttpRequest` from
:py:class:`smithy_http.aio.HTTPRequest`"""
headers_list = []
if "Host" not in request.fields:
request.fields.set_field(
Field(name="Host", values=[request.destination.host])
)

for fld in request.fields.entries.values():
if fld.kind != FieldPosition.HEADER:
# TODO: Use literal values for "header"/"trailer".
if fld.kind.value != FieldPosition.HEADER.value:
continue
for val in fld.values:
headers_list.append((fld.name, val))
Expand Down
4 changes: 4 additions & 0 deletions packages/smithy-http/src/smithy_http/interfaces/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,10 @@ def __len__(self) -> int:
"""Get total number of Field entries."""
...

def __contains__(self, key: str) -> bool:
"""Allows in/not in checks on Field entries."""
...

def get_by_type(self, kind: FieldPosition) -> list[Field]:
"""Helper function for retrieving specific types of fields.

Expand Down