Skip to content

Conversation

@alextwoods
Copy link
Contributor

Description of changes:
These changes are temporary and should be replaced by larger signer fixes.

Fixes 2 typing mismatches with the current signers:

  • request -> http_request in the signature for sign.
  • Adds a runtime_checkable AWSCredentialsIdentity(Protocol) to allow the instance_of check to succeed.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@alextwoods alextwoods requested a review from a team as a code owner March 12, 2025 19:06
@alextwoods alextwoods merged commit 05b8ce6 into smithy-lang:develop Mar 12, 2025
2 checks passed
@alextwoods alextwoods deleted the fix_signer_shorterm branch March 12, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants