Skip to content

Pass new request into signer for canonical_request #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 12, 2025
Merged

Pass new request into signer for canonical_request #434

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
286133e
Pass new request into signer for canonical_request
nateprewitt Mar 12, 2025
4531831
Test fields aren't mutated on original request
nateprewitt Mar 12, 2025
167b613
Merge branch 'develop' into signer_fix
nateprewitt Mar 12, 2025
db4b9fd
Fix new parameter name
nateprewitt Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/aws-sdk-signers/src/aws_sdk_signers/signers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ async def sign(
# Construct core signing components
canonical_request = await self.canonical_request(
signing_properties=signing_properties,
request=request,
request=new_request,
)
string_to_sign = await self.string_to_sign(
canonical_request=canonical_request,
Expand Down