Ensure streams get closed and don't wait on concurrent futures in crt #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
commented
Mar 14, 2025
| self.response: R | None = None | ||
|
|
||
| async def await_output(self) -> tuple[R, AsyncEventReceiver[O]]: | ||
| async_reader = AsyncBytesReader((await self._awaitable_response).body) |
Contributor
Author
There was a problem hiding this comment.
This is formatted a bit unfortunately. I just wrapped it in a try/except
JordonPhillips
commented
Mar 14, 2025
| if self._received_chunks: | ||
| return self._received_chunks.popleft() | ||
| elif self._stream.completion_future.done(): | ||
| elif self._completion_future.done(): |
Contributor
Author
There was a problem hiding this comment.
Note that async futures return immediately on done, whereas concurrent futures can wait... forever
alextwoods
reviewed
Mar 14, 2025
packages/aws-event-stream/src/aws_event_stream/_private/deserializers.py
Outdated
Show resolved
Hide resolved
alextwoods
reviewed
Mar 17, 2025
alextwoods
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.