Skip to content

Conversation

@haydenbaker
Copy link
Contributor

@haydenbaker haydenbaker commented Mar 14, 2025

Description of changes:

example:

GetCity = APIOperation(
    input=GetCityInput,
    output=GetCityOutput,
    schema=_SCHEMA_GET_CITY,
    input_schema=_SCHEMA_GET_CITY_INPUT,
    output_schema=_SCHEMA_GET_CITY_OUTPUT,
    error_registry=TypeRegistry(
        {
            ShapeID("example.weather#NoSuchResource"): NoSuchResource,
        }
    ),
    effective_auth_schemes=[ShapeID("smithy.api#noAuth")],
)

CI run: https://github.com/smithy-lang/smithy-python/actions/runs/13866147289/job/38805575326?pr=445

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@haydenbaker haydenbaker requested a review from a team as a code owner March 14, 2025 22:04
@haydenbaker haydenbaker changed the base branch from haydenbaker/add-type-registry-and-misc to develop March 14, 2025 22:07
@haydenbaker haydenbaker force-pushed the haydenbaker/add-opgen branch from 87ec025 to 10103d0 Compare March 14, 2025 22:08
@haydenbaker haydenbaker changed the base branch from develop to haydenbaker/add-type-registry-and-misc March 14, 2025 22:09

// We add a symbol for the method in the client as a property, whereas the actual
// operation symbol points to the generated type for it
return createGeneratedSymbolBuilder(shape, getDefaultShapeName(shape), SHAPES_FILE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return createGeneratedSymbolBuilder(shape, getDefaultShapeName(shape), SHAPES_FILE)
var name = CaseUtils.toSnakeCase(getDefaultShapeName(shape)).toUpperCase(Locale.ENGLISH);
return createGeneratedSymbolBuilder(shape, name, SHAPES_FILE)

Base automatically changed from haydenbaker/add-type-registry-and-misc to develop March 17, 2025 16:50
@haydenbaker haydenbaker force-pushed the haydenbaker/add-opgen branch from 6f55b49 to c8c0ce4 Compare March 17, 2025 16:54
@haydenbaker haydenbaker merged commit 6db4183 into develop Mar 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants