Update interceptors #449
Merged
Update interceptors #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateprewitt
approved these changes
Mar 18, 2025
Contributor
nateprewitt
left a comment
nateprewitt
left a comment
There was a problem hiding this comment.
Conceptually this all looks good, I need to go take a look at this compared to the other inflight work to see if we're breaking anything though.
alextwoods
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates interceptors to be dataclasses with stronger typing and updates the generated request pipeline to use them. The pipeline updates are fairly extensive, but it has the advantage of removing most of the casting that was littered all over the place. This also ensures the immutability of the explicit properties.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.