Fix minor generator issues #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateprewitt
force-pushed
the
generator_cleanup
branch
from
92bccd6 to
d35a8df
Compare
jonathan343
reviewed
Mar 24, 2025
...ws/core/src/main/java/software/amazon/smithy/python/aws/codegen/AwsUserAgentIntegration.java
Outdated
Show resolved
Hide resolved
...ws/core/src/main/java/software/amazon/smithy/python/aws/codegen/AwsUserAgentIntegration.java
Outdated
Show resolved
Hide resolved
JordonPhillips
previously requested changes
Mar 25, 2025
codegen/core/src/main/java/software/amazon/smithy/python/codegen/generators/InitGenerator.java
Outdated
Show resolved
Hide resolved
nateprewitt
force-pushed
the
generator_cleanup
branch
from
d35a8df to
0955b75
Compare
nateprewitt
force-pushed
the
generator_cleanup
branch
from
0955b75 to
97590e6
Compare
jonathan343
approved these changes
Apr 1, 2025
SamRemis
pushed a commit
to SamRemis/smithy-python
that referenced
this pull request
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up a couple minor generator items that I noticed getting formatted out of the code every time.