Skip to content

Move build-system to hatchling for generated clients #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

Move build-system to hatchling for generated clients #475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions ...n/core/src/main/java/software/amazon/smithy/python/codegen/generators/SetupGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,6 @@ private static void writePyproject(
writers.useFileWriter("pyproject.toml", "", writer -> {
writer.pushState(new PyprojectSection(dependencies));
writer.write("""
[build-system]
requires = ["setuptools", "setuptools-scm", "wheel"]
build-backend = "setuptools.build_meta"

[project]
name = $1S
version = $2S
Expand All @@ -145,7 +141,7 @@ private static void writePyproject(
""", settings.moduleName(), settings.moduleVersion(), settings.moduleDescription());

Optional.ofNullable(dependencies.get(PythonDependency.Type.DEPENDENCY.getType())).ifPresent(deps -> {
writer.openBlock("dependencies = [", "]", () -> writeDependencyList(writer, deps.values()));
writer.openBlock("dependencies = [", "]\n", () -> writeDependencyList(writer, deps.values()));
});

Optional<Collection<SymbolDependency>> testDeps =
Expand All @@ -161,17 +157,23 @@ private static void writePyproject(
}

testDeps.ifPresent(deps -> {
writer.openBlock("tests = [", "]", () -> writeDependencyList(writer, deps));
writer.openBlock("tests = [", "]\n", () -> writeDependencyList(writer, deps));
});

docsDeps.ifPresent(deps -> {
writer.openBlock("docs = [", "]", () -> writeDependencyList(writer, deps));
writer.openBlock("docs = [", "]\n", () -> writeDependencyList(writer, deps));
});

// TODO: remove the pyright global suppressions after the serde redo is done
writer.write("""
[tool.setuptools.packages.find]
exclude=["tests*"]
[build-system]
requires = ["hatchling"]
build-backend = "hatchling.build"

[tool.hatch.build]
exclude = [
"tests",
]

[tool.pyright]
typeCheckingMode = "strict"
Expand Down