Skip to content

Fix missing deepcopy import for event stream operations #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2025
Merged

Fix missing deepcopy import for event stream operations #589

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8000e36
Fix missing deepcopy import for event stream operations
SamRemis Oct 26, 2025
075e21e
Updates based on feedback
SamRemis Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions codegen/core/src/main/java/software/amazon/smithy/python/codegen/ClientGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ raise ExpectationNotMetError("protocol and transport MUST be set on the config t

private void generateEventStreamOperation(PythonWriter writer, OperationShape operation) {
writer.pushState(new OperationSection(service, operation));
writer.addStdlibImport("copy", "deepcopy");
Copy link
Contributor

@jonathan343 jonathan343 Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding this here, I think we should push this up to the writeSharedOperationInit method

writer.addDependency(SmithyPythonDependency.SMITHY_CORE);
writer.addDependency(SmithyPythonDependency.SMITHY_AWS_CORE.withOptionalDependencies("eventstream"));
var operationSymbol = symbolProvider.toSymbol(operation);
Expand Down
Loading