Add timeout error classification #590
Open
+226
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan343
reviewed
Nov 4, 2025
| if response.reason is not None: | ||
| message += f" - reason: {response.status}" | ||
|
|
||
| if response.status == 408: |
Comment on lines
+143
to
+145
| "AWS_IO_SOCKET_TIMEOUT", | ||
| "AWS_IO_CHANNEL_ERROR_SOCKET_TIMEOUT", | ||
| "AWS_ERROR_HTTP_REQUEST_TIMEOUT", |
There was a problem hiding this comment.
Where are these coming from? Is this an exhaustive list for CRT errors?
| ) | ||
| except Exception as e: | ||
| error_info = self.transport.get_error_info(e) | ||
| if error_info.is_timeout_error: |
There was a problem hiding this comment.
Based off the docstring for ClientTimeoutError, shouldn't we be checking the fault value? What if the fault is set to server?
Exception raised when a client-side timeout occurs.
| if isinstance(exception, AwsCrtError) and exception.name in timeout_indicators: | ||
| return ErrorInfo(is_timeout_error=True, fault="client") | ||
|
|
||
| return ErrorInfo(is_timeout_error=False) |
There was a problem hiding this comment.
why set fault="client" above and not here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request centralizes and clarifies timeout handling across the async client and transport layers by adding a transport-level error classification API and surfacing transport-detected timeouts as a dedicated ClientTimeoutError. Transports now return an ErrorInfo that indicates whether an exception represents a timeout and whether the fault is client- or server-side, and the core async client consults that information and raises ClientTimeoutError when appropriate so callers see a single, consistent exception for client-side timeouts.
ClientTransport implementations must now implement get_error_info(exception, **kwargs) and return an ErrorInfo indicating whether the exception is a timeout and whether the fault is client- or server-side. The break was required so the core async client can reliably classify transport errors and raise a single ClientTimeoutError for client-side timeouts. This information is necessary for handling errors as a part of retries.