Restrict init file gen to package directories #596
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateprewitt
reviewed
Nov 4, 2025
| .stream() | ||
| .map(Paths::get) | ||
| .filter(path -> !path.getParent().equals(context.fileManifest().getBaseDir())) | ||
| .filter(path -> PACKAGE_DIRECTORIES.contains(path.getName(0).toString())) |
There was a problem hiding this comment.
path.getName(0) in this case is always the first path part rather than a qualified path? e.g. src and not /src or aws-sdk-bedrock-runtime/src?
nateprewitt
reviewed
Nov 4, 2025
| Changes made by these plugins only apply for the duration of the operation | ||
| execution and will not affect any other operation invocations. | ||
| """); | ||
| execution and will not affect any other operation invocations."""); |
There was a problem hiding this comment.
This seems a little strange for the fix. Is it because this adds the newline we need but our actual writer is also always appending a newline so we get two? I think this issue was affecting multiple places. I wonder if we should be doing something more like trimming extra newlines from the end of the final docstring (or not appending them to the end).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
__init__.pyfile generation in non-package directories such asdocs/*.Examples
Bedrock Runtime
Before:
After:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.