Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As support for Android has solidified and is now official, efforts are being made to add Android support to existing swift packages and their dependencies (smithy-swift being one).
Most of the time, packages that support linux also support Android, or require minimal changes.
From what I tested locally, there seems to be an issue with "libxml" not being present, but that speaks more to the local host being MacOS.
Adding this CI workflow can help making sure changes don't break Android support.
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.