- 
                Notifications
    
You must be signed in to change notification settings  - Fork 35
 
fix: Consider an empty string header value to be present #832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
ba039df
              6b0612a
              c75e7c4
              802fc65
              6b07c0a
              File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | 
|---|---|---|
| 
          
            
          
           | 
    @@ -138,15 +138,7 @@ public struct Headers: Sendable { | |
| } | ||
| 
     | 
||
| public func exists(name: String) -> Bool { | ||
| guard headers.index(of: name) != nil else { | ||
| return false | ||
| } | ||
| 
     | 
||
| guard let value = value(for: name) else { | ||
| return false | ||
| } | ||
| 
     | 
||
| return !value.isEmpty | ||
| headers.index(of: name) != nil | ||
| 
         There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The previous definition of  I suspect that the reason for this logic is that the previous developers changed the definition of "exists" to suit the behavior demanded by empty-header protocol tests, which is wrong and is being fixed by Smithy team.  | 
||
| } | ||
| 
     | 
||
| /// The dictionary representation of all headers. | ||
| 
          
            
          
           | 
    ||
| Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -1,13 +1,14 @@ | ||
| /* | ||
| * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| * SPDX-License-Identifier: Apache-2.0. | ||
| */ | ||
| // | ||
| // Copyright Amazon.com Inc. or its affiliates. | ||
| // All Rights Reserved. | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // | ||
| 
     | 
||
| import SmithyHTTPAPI | ||
| import XCTest | ||
| import ClientRuntime | ||
| 
     | 
||
| class HttpHeadersTests: XCTestCase { | ||
| class HeadersTests: XCTestCase { | ||
| 
     | 
||
| var headersAsDictionaryWithArray = [String: [String]]() | ||
| var headersAsDictionary = [String: String]() | ||
| 
          
            
          
           | 
    @@ -123,4 +124,21 @@ class HttpHeadersTests: XCTestCase { | |
| XCTAssertEqual(headerA, headerB) | ||
| XCTAssertEqual(headerA.hashValue, headerB.hashValue) | ||
| } | ||
| 
     | 
||
| // MARK: - exists() | ||
| 
     | 
||
| func test_exists_trueIfHeaderExists() { | ||
| let subject = Headers(["a": "abc"]) | ||
| XCTAssertTrue(subject.exists(name: "a")) | ||
| } | ||
| 
     | 
||
| func test_exists_falseIfHeaderDoesntExist() { | ||
| let subject = Headers(["a": "abc"]) | ||
| XCTAssertFalse(subject.exists(name: "b")) | ||
| } | ||
| 
     | 
||
| func test_exists_trueIfHeaderValueIsEmptyString() { | ||
| let subject = Headers(["a": ""]) | ||
| XCTAssertTrue(subject.exists(name: "a")) | ||
| } | ||
| 
         There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These new tests check the expected behavior for the   | 
||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a new test target & moved the
Headerstests into it, sinceHeadersis in theSmithyHTTPAPImodule.