Draft
Conversation
jbelkins
commented
Nov 21, 2024
| group = "publishing" | ||
| description = "Assembles Kotlin sources jar" | ||
| classifier = "sources" | ||
| archiveClassifier = "sources" |
Contributor
Author
There was a problem hiding this comment.
Property renamed in Gradle 8
jbelkins
commented
Nov 21, 2024
| html.destination = file("$buildDir/reports/jacoco") | ||
| xml.required.set(false) | ||
| csv.required.set(false) | ||
| html.outputLocation.set(file("$buildDir/reports/jacoco")) |
Contributor
Author
There was a problem hiding this comment.
Test report config updated & taken from smithy project
jbelkins
commented
Nov 21, 2024
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.2-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.11.1-bin.zip |
Contributor
Author
There was a problem hiding this comment.
Automatically generated by Gradle upgrade command
jbelkins
commented
Nov 21, 2024
| @@ -1,7 +1,7 @@ | |||
| #!/usr/bin/env sh | |||
| #!/bin/sh | |||
Contributor
Author
There was a problem hiding this comment.
Automatically generated by Gradle upgrade command
jbelkins
commented
Nov 21, 2024
| set JAVA_EXE=java.exe | ||
| %JAVA_EXE% -version >NUL 2>&1 | ||
| if "%ERRORLEVEL%" == "0" goto init | ||
| if "%ERRORLEVEL%" == "0" goto execute |
Contributor
Author
There was a problem hiding this comment.
Automatically generated by Gradle upgrade command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Gradle update instructions are here:
https://docs.gradle.org/current/userguide/upgrading_version_7.html
Updates the project from Gradle 7.2 to 8.11.1 (the latest Gradle version).
This brings us to parity with https://github.com/smithy-lang/smithy which is also on Gradle 8.
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.