Skip to content

fix(node-http-handler): omit setting cache setting on request init when using default value #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2024
Merged

fix(node-http-handler): omit setting cache setting on request init when using default value #1411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6894b47
Fixes #1407
nicksrandall Sep 20, 2024
1c13b6b
changeset
nicksrandall Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/good-cheetahs-wait.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@smithy/fetch-http-handler": patch
---

Omit setting cache setting on request init when using default value
6 changes: 5 additions & 1 deletion packages/fetch-http-handler/src/fetch-http-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,12 @@ export class FetchHttpHandler implements HttpHandler<FetchHttpHandlerConfig> {
headers: new Headers(request.headers),
method: method,
credentials,
cache: this.config!.cache ?? "default",
};
// cache property is not supported in workerd runtime
// TODO: can we feature detect support for cache and not set this property when not supported?
if (this.config?.cache) {
requestOptions.cache = this.config.cache;
}

if (body) {
requestOptions.duplex = "half";
Expand Down
Loading