Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/small-gifts-tease.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@smithy/smithy-client": patch
---

serialize empty strings and collections in headers
1 change: 1 addition & 0 deletions packages/smithy-client/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export * from "./exceptions";
export * from "./extended-encode-uri-component";
export * from "./get-array-if-single-item";
export * from "./get-value-from-text-node";
export * from "./is-serializable-header-value";
export * from "./lazy-json";
export * from "./object-mapping";
export * from "./parse-utils";
Expand Down
23 changes: 23 additions & 0 deletions packages/smithy-client/src/is-serializable-header-value.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import { isSerializableHeaderValue } from "./is-serializable-header-value";

describe(isSerializableHeaderValue.name, () => {
it("considers empty strings serializable", () => {
expect(isSerializableHeaderValue("")).toBe(true);
});

it("considers empty collections serializable", () => {
expect(isSerializableHeaderValue(new Set())).toBe(true);
expect(isSerializableHeaderValue([])).toBe(true);
});

it("considers most falsy data values to be serializable", () => {
expect(isSerializableHeaderValue(false)).toBe(true);
expect(isSerializableHeaderValue(0)).toBe(true);
expect(isSerializableHeaderValue(new Date(0))).toBe(true);
});

it("considered undefined and null to be unserializable", () => {
expect(isSerializableHeaderValue(undefined)).toBe(false);
expect(isSerializableHeaderValue(null)).toBe(false);
});
});
7 changes: 7 additions & 0 deletions packages/smithy-client/src/is-serializable-header-value.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
/**
* @internal
* @returns whether the header value is serializable.
*/
export const isSerializableHeaderValue = (value: any) => {
return value != null;
};
Loading