Skip to content

Update SmithyVersion to 1.56.0 #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2025
Merged

Update SmithyVersion to 1.56.0 #1573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b694e56
fix failing protocol test
smilkuri May 1, 2025
7823a01
update order of writing headers
smilkuri May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
smithyVersion=1.55.0
smithyVersion=1.56.0
smithyGradleVersion=1.2.0
23 changes: 11 additions & 12 deletions ...a/software/amazon/smithy/typescript/codegen/integration/HttpBindingProtocolGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -979,6 +979,12 @@ private void writeRequestHeaders(
// Only set the content type if one can be determined.
writeContentTypeHeader(context, operation, true);
writeDefaultInputHeaders(context, operation);
if (inputPresent) {
// Handle assembling prefix headers.
for (HttpBinding binding : prefixHeaders) {
writePrefixHeaders(context, binding);
}
}

if (inputPresent) {
for (HttpBinding binding : headers) {
Expand All @@ -987,13 +993,6 @@ private void writeRequestHeaders(
}

flushHeadersBuffer(writer);

if (inputPresent) {
// Handle assembling prefix headers.
for (HttpBinding binding : prefixHeaders) {
writePrefixHeaders(context, binding);
}
}
writer.dedent();
writer.write(closing);
}
Expand Down Expand Up @@ -1103,16 +1102,16 @@ private void writeResponseHeaders(
writeContentTypeHeader(context, operationOrError, false);
injectExtraHeaders.run();

// Handle assembling prefix headers.
for (HttpBinding binding : bindingIndex.getResponseBindings(operationOrError, Location.PREFIX_HEADERS)) {
writePrefixHeaders(context, binding);
}

for (HttpBinding binding : bindingIndex.getResponseBindings(operationOrError, Location.HEADER)) {
writeNormalHeader(context, binding);
}

flushHeadersBuffer(writer);

// Handle assembling prefix headers.
for (HttpBinding binding : bindingIndex.getResponseBindings(operationOrError, Location.PREFIX_HEADERS)) {
writePrefixHeaders(context, binding);
}
});
}

Expand Down