Skip to content

fix(codegen): use undefined placeholder for unhandled trait #1629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

fix(codegen): use undefined placeholder for unhandled trait #1629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion .../src/main/java/software/amazon/smithy/typescript/codegen/schema/SchemaTraitGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import software.amazon.smithy.model.traits.EventHeaderTrait;
import software.amazon.smithy.model.traits.EventPayloadTrait;
import software.amazon.smithy.model.traits.HostLabelTrait;
import software.amazon.smithy.model.traits.HttpChecksumRequiredTrait;
import software.amazon.smithy.model.traits.HttpErrorTrait;
import software.amazon.smithy.model.traits.HttpHeaderTrait;
import software.amazon.smithy.model.traits.HttpLabelTrait;
Expand Down Expand Up @@ -60,6 +61,7 @@ public class SchemaTraitGenerator {
HttpPayloadTrait.ID,
HttpQueryParamsTrait.ID,
HttpResponseCodeTrait.ID,
HttpChecksumRequiredTrait.ID,
HostLabelTrait.ID,
SparseTrait.ID,
SensitiveTrait.ID,
Expand Down Expand Up @@ -124,7 +126,17 @@ public String serializeTraitData(Trait trait, StringStore stringStore) {
} else if (SchemaTraitExtension.INSTANCE.contains(trait)) {
return SchemaTraitExtension.INSTANCE.render(trait);
}

if (trait instanceof StringTrait stringTrait) {
return """
/* unhandled trait \s""" + "`" + trait.getClass().getSimpleName() + "` */ "
+ stringStore.var(stringTrait.getValue());
} else if (trait instanceof AnnotationTrait) {
return """
/* unhandled trait \s""" + "`" + trait.getClass().getSimpleName() + "` */ "
+ ANNOTATION_TRAIT_VALUE;
}
return """
/* unhandled trait \s""" + "`" + trait.getClass().getSimpleName() + "` */";
/* unhandled trait \s""" + "`" + trait.getClass().getSimpleName() + "` */ void 0";
}
}