feat(core/eventStreams): add event stream mixin for HttpProtocols, schema-serde #1671
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1600
Description of changes:
PR moves event stream handling of schema-serde to a separate submodule called
@smithy/core/eventStreams. It is asynchronously loaded byHttpProtocolextender classes when the functionality is needed. This should help with chunking in bundlers.Additionally, the initial-request and initial-response message types for RPC protocols are handled by this implementation, whereas they are not handled by the existing model-ignorant codegen approach.
The implementation reuses the
@smithy/eventstream-serde-universalstream and codec functionality, replacing only the part that was code-generated in protocol files, i.e. calls to theclient.config.eventStreamMarshaller.Old code example:
New code example:
(In the PR diff)
context: within a schema-serde Protocol implementation