fix(codegen): fix header type codegen for event streams #1694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
commented
Sep 15, 2025
| String memberName = headerMember.getMemberName(); | ||
| Shape target = model.expectShape(headerMember.getTarget()); | ||
| writer.openBlock("if (input.$L) {", "}", memberName, () -> { | ||
| writer.openBlock("if (input.$L != null) {", "}", memberName, () -> { |
There was a problem hiding this comment.
allow zero numbers and empty strings
kuhe
commented
Sep 15, 2025
| writer.openBlock("if (input.$L != null) {", "}", memberName, () -> { | ||
| writer.write("headers[$1S] = { type: $2S, value: input.$1L }", memberName, | ||
| getEventHeaderType(headerMember)); | ||
| getEventHeaderType(target)); |
There was a problem hiding this comment.
the member target shape type is what runs against the switch statement.
Using the member itself always goes to the default branch because the shape type is MEMBER.
kuhe
commented
Sep 15, 2025
| return "binary"; | ||
| default: | ||
| return "binary"; | ||
| throw new IllegalArgumentException("Unsupported event header shape type: " + shape.getType()); |
There was a problem hiding this comment.
there should be no default, since all supported types are accounted for, see https://smithy.io/2.0/spec/streaming.html#eventheader-trait
kuhe
force-pushed
the
fix/event-stream
branch
from
fb3c44d to
62676ec
Compare
trivikr
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal JS-6222
See inline comments