Skip to content

fix(codegen): fix header type codegen for event streams #1694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2025
Merged

fix(codegen): fix header type codegen for event streams #1694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...main/java/software/amazon/smithy/typescript/codegen/integration/EventStreamGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,9 +333,9 @@ private void writeEventHeaders(GenerationContext context, StructureShape event)
for (MemberShape headerMember : headerMembers) {
String memberName = headerMember.getMemberName();
Shape target = model.expectShape(headerMember.getTarget());
writer.openBlock("if (input.$L) {", "}", memberName, () -> {
writer.openBlock("if (input.$L != null) {", "}", memberName, () -> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allow zero numbers and empty strings

writer.write("headers[$1S] = { type: $2S, value: input.$1L }", memberName,
getEventHeaderType(headerMember));
getEventHeaderType(target));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the member target shape type is what runs against the switch statement.

Using the member itself always goes to the default branch because the shape type is MEMBER.

});
}
}
Expand All @@ -356,7 +356,7 @@ private String getEventHeaderType(Shape shape) {
case BLOB:
return "binary";
default:
return "binary";
throw new IllegalArgumentException("Unsupported event header shape type: " + shape.getType());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should be no default, since all supported types are accounted for, see https://smithy.io/2.0/spec/streaming.html#eventheader-trait

}
}

Expand Down
Loading