Skip to content

Conversation

@trivikr
Copy link
Contributor

@trivikr trivikr commented Oct 1, 2025

Issue #, if available:
The first party gradle/actions/setup-gradle is better, as it does configuration caching
Details in actions/setup-java#588

Description of changes:
Replaces cache: gradle in actions/setup-java with gradle/actions/setup-gradle


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner October 1, 2025 17:41
@trivikr
Copy link
Contributor Author

trivikr commented Oct 1, 2025

The setup-gradle action checks for validity for wrapper jars

All Gradle Wrapper jars are valid
  ✓ Found known Gradle Wrapper JAR files:
    7d3a4ac4de1c32b59bc6a4eb8ecb8e612ccd0cf1ae1e99f66902da64df296172 gradle/wrapper/gradle-wrapper.jar

https://github.com/smithy-lang/smithy-typescript/actions/runs/18170692280/job/51724293977?pr=1724

The explicit call to gradle/actions/wrapper-validation can be removed.

@trivikr
Copy link
Contributor Author

trivikr commented Oct 1, 2025

Cache is read-only by default

Post job cleanup.
In post-action step
Cache is read-only: will not save state for use in subsequent builds.
Generating Job Summary
Completed post-action step

https://github.com/smithy-lang/smithy-typescript/actions/runs/18170692280/job/51724293977?pr=1724

Docs: https://github.com/gradle/actions/blob/main/docs/setup-gradle.md#using-the-cache-read-only
We may want to set cache-write-only: true just for testing

@trivikr
Copy link
Contributor Author

trivikr commented Oct 1, 2025

Most of the cache was saved

  Not saving configuration-cache state, as no encryption key was provided
  /opt/homebrew/bin/gtar --posix -cf cache.tzst --exclude cache.tzst -P -C /Users/runner/work/smithy-typescript/smithy-typescript --files-from manifest.txt --delay-directory-restore --use-compress-program zstdmt
  /opt/homebrew/bin/gtar --posix -cf cache.tzst --exclude cache.tzst -P -C /Users/runner/work/smithy-typescript/smithy-typescript --files-from manifest.txt --delay-directory-restore --use-compress-program zstdmt
  /opt/homebrew/bin/gtar --posix -cf cache.tzst --exclude cache.tzst -P -C /Users/runner/work/smithy-typescript/smithy-typescript --files-from manifest.txt --delay-directory-restore --use-compress-program zstdmt
  /opt/homebrew/bin/gtar --posix -cf cache.tzst --exclude cache.tzst -P -C /Users/runner/work/smithy-typescript/smithy-typescript --files-from manifest.txt --delay-directory-restore --use-compress-program zstdmt
  /opt/homebrew/bin/gtar --posix -cf cache.tzst --exclude cache.tzst -P -C /Users/runner/work/smithy-typescript/smithy-typescript --files-from manifest.txt --delay-directory-restore --use-compress-program zstdmt
  Sent 667677 of 667677 (100.0%), 2.5 MBs/sec
  Saved cache entry with key gradle-instrumented-jars-v1-34ff00df415bbe3966baeef383e321e7 from /Users/runner/.gradle/caches/jars-*/*/ in 596ms
  Sent 110059 of 110059 (100.0%), 1.4 MBs/sec
  Saved cache entry with key gradle-groovy-dsl-v1-8f2f6df19e21820d87ea303a0e1efbac from /Users/runner/.gradle/caches/*/groovy-dsl/*/ in 642ms
  Sent 199992 of 199992 (100.0%), 3.1 MBs/sec
  Saved cache entry with key gradle-kotlin-dsl-v1-6c9c199eac00a2d828d9ccb18ac05938 from /Users/runner/.gradle/caches/*/kotlin-dsl/accessors/*/,/Users/runner/.gradle/caches/*/kotlin-dsl/scripts/*/ in 1349ms
  Sent 54788096 of 133844809 (40.9%), 51.8 MBs/sec
  Sent 38666240 of 41485736 (93.2%), 36.9 MBs/sec
  Sent 41485736 of 41485736 (100.0%), 33.9 MBs/sec
  /opt/homebrew/bin/gtar --posix -cf cache.tzst --exclude cache.tzst -P -C /Users/runner/work/smithy-typescript/smithy-typescript --files-from manifest.txt --delay-directory-restore --use-compress-program zstdmt
  Saved cache entry with key gradle-generated-gradle-jars-v1-998f666cf95b15164a53e350e73f3833 from /Users/runner/.gradle/caches/9.0.0/generated-gradle-jars/gradle-api-9.0.0.jar in 2874ms
  /opt/homebrew/bin/gtar --posix -cf cache.tzst --exclude cache.tzst -P -C /Users/runner/work/smithy-typescript/smithy-typescript --files-from manifest.txt --delay-directory-restore --use-compress-program zstdmt
  Sent 111804416 of 133844809 (83.5%), 53.1 MBs/sec
  Sent 133844809 of 133844809 (100.0%), 51.2 MBs/sec
  Saved cache entry with key gradle-wrapper-zips-v1-579f250a568e785f3bb35fedea868447 from /Users/runner/.gradle/wrapper/dists/gradle-9.0.0-bin/d6wjpkvcgsg3oed0qlfss3wgl in 4098ms
  Sent 79822848 of 95363325 (83.7%), 76.0 MBs/sec
  Sent 95363325 of 95363325 (100.0%), 59.6 MBs/sec
  Saved cache entry with key gradle-dependencies-v1-811472193b97f4e4170d79af825f5277 from /Users/runner/.gradle/caches/modules-*/files-*/*/*/*/* in 5000ms
  Sent 27371044 of 27371044 (100.0%), 32.4 MBs/sec
  Saved cache entry with key gradle-transforms-v1-a458b16fcb777278d9a1263ddee7b432 from /Users/runner/.gradle/caches/transforms-4/*/,/Users/runner/.gradle/caches/*/transforms/*/ in 4175ms
  /opt/homebrew/bin/gtar --posix -cf cache.tzst --exclude cache.tzst -P -C /Users/runner/work/smithy-typescript/smithy-typescript --files-from manifest.txt --delay-directory-restore --use-compress-program zstdmt
  Sent 1504157 of 1504157 (100.0%), 8.4 MBs/sec
  Saved cache entry with key gradle-home-v1|macOS-ARM64|build[aaa77f5c8d776509331934c0a6b1e933]-8cceca6da4a32b3458e97a8ab4f1d95a9f1c39ba from /Users/runner/.gradle/caches,/Users/runner/.gradle/notifications,/Users/runner/.gradle/.setup-gradle in 628ms

https://github.com/smithy-lang/smithy-typescript/actions/runs/18171040946/job/51725531885?pr=1724

Configuration cache was skipped since it requires cache-encryption-key
https://github.com/gradle/actions/blob/main/docs/setup-gradle.md#saving-configuration-cache-data

@trivikr
Copy link
Contributor Author

trivikr commented Oct 1, 2025

Confirmed that cache is restored

  Cache hit for restore-key: gradle-home-v1|macOS-ARM64|build[aaa77f5c8d776509331934c0a6b1e933]-c39fc2c7ffeebe20271c312d649c30f49cdc4e9a
  Received 0 of 1500674 (0.0%), 0.0 MBs/sec
  Received 1500674 of 1500674 (100.0%), 1.2 MBs/sec
  Cache Size: ~1 MB (1500674 B)
  /opt/homebrew/bin/gtar -xf /Users/runner/work/_temp/de03f90c-2b2b-4f64-920d-4711530a6be2/cache.tzst -P -C /Users/runner/work/smithy-typescript/smithy-typescript --delay-directory-restore --use-compress-program unzstd
  Cache restored successfully
  Restored cache entry with key gradle-home-v1|macOS-ARM64|build[aaa77f5c8d776509331934c0a6b1e933]-7a7d441efc09f59600581bb2a7e4b78cb2746328 to /Users/runner/.gradle/caches,/Users/runner/.gradle/notifications,/Users/runner/.gradle/.setup-gradle in 2200ms
  Cache hit for: gradle-transforms-v1-a458b16fcb777278d9a1263ddee7b432
  Cache hit for: gradle-kotlin-dsl-v1-6c9c199eac00a2d828d9ccb18ac05938
  Cache hit for: gradle-instrumented-jars-v1-cf294705d8f47bcb942ec32053238e0f
  Cache hit for: gradle-wrapper-zips-v1-579f250a568e785f3bb35fedea868447
  Cache hit for: gradle-generated-gradle-jars-v1-998f666cf95b15164a53e350e73f3833
  Cache hit for: gradle-dependencies-v1-811472193b97f4e4170d79af825f5277
  Cache hit for: gradle-groovy-dsl-v1-6e6aebd8c5f08354ab436263481b39cd
  Received 110088 of 110088 (100.0%), 0.3 MBs/sec
  Cache Size: ~0 MB (110088 B)
  /opt/homebrew/bin/gtar -xf /Users/runner/work/_temp/e70fe82f-6b5b-4d33-abb6-dd6d1966d3ac/cache.tzst -P -C /Users/runner/work/smithy-typescript/smithy-typescript --delay-directory-restore --use-compress-program unzstd
  Cache restored successfully
  Restored cache entry with key gradle-groovy-dsl-v1-6e6aebd8c5f08354ab436263481b39cd to /Users/runner/.gradle/caches/*/groovy-dsl/*/ in 1251ms
  Received 199992 of 199992 (100.0%), 0.3 MBs/sec
  Cache Size: ~0 MB (199992 B)
  /opt/homebrew/bin/gtar -xf /Users/runner/work/_temp/99a5f9ca-4129-4b0a-910d-8dc1210ee673/cache.tzst -P -C /Users/runner/work/smithy-typescript/smithy-typescript --delay-directory-restore --use-compress-program unzstd
  Received 667373 of 667373 (100.0%), 0.7 MBs/sec
  Cache Size: ~1 MB (667373 B)
  /opt/homebrew/bin/gtar -xf /Users/runner/work/_temp/6f49384c-9438-41a9-a9df-b87144d4f4d3/cache.tzst -P -C /Users/runner/work/smithy-typescript/smithy-typescript --delay-directory-restore --use-compress-program unzstd
  Received 0 of 95363325 (0.0%), 0.0 MBs/sec
  Received 0 of 41485736 (0.0%), 0.0 MBs/sec
  Received 0 of 133844809 (0.0%), 0.0 MBs/sec
  Received 0 of 27371044 (0.0%), 0.0 MBs/sec
  Cache restored successfully
  Restored cache entry with key gradle-instrumented-jars-v1-cf294705d8f47bcb942ec32053238e0f to /Users/runner/.gradle/caches/jars-*/*/ in 1757ms
  Cache restored successfully
  Restored cache entry with key gradle-kotlin-dsl-v1-6c9c199eac00a2d828d9ccb18ac05938 to /Users/runner/.gradle/caches/*/kotlin-dsl/accessors/*/,/Users/runner/.gradle/caches/*/kotlin-dsl/scripts/*/ in 2253ms
  Received 12582912 of 95363325 (13.2%), 6.0 MBs/sec
  Received 8388608 of 41485736 (20.2%), 4.0 MBs/sec
  Received 12582912 of 133844809 (9.4%), 6.0 MBs/sec
  Received 10593828 of 27371044 (38.7%), 5.0 MBs/sec
  Received 27371044 of 27371044 (100.0%), 9.0 MBs/sec
  Cache Size: ~26 MB (27371044 B)
  Received 29360128 of 95363325 (30.8%), 9.2 MBs/sec
  Received 37291432 of 41485736 (89.9%), 11.5 MBs/sec
  Received 46137344 of 133844809 (34.5%), 14.4 MBs/sec
  /opt/homebrew/bin/gtar -xf /Users/runner/work/_temp/7a78ec61-e001-4346-9b21-4c414ec367fa/cache.tzst -P -C /Users/runner/work/smithy-typescript/smithy-typescript --delay-directory-restore --use-compress-program unzstd
  Received 41485736 of 41485736 (100.0%), 10.3 MBs/sec
  Cache Size: ~40 MB (41485736 B)
  /opt/homebrew/bin/gtar -xf /Users/runner/work/_temp/2ce5977d-bf81-41e3-9fbd-239e4398060f/cache.tzst -P -C /Users/runner/work/smithy-typescript/smithy-typescript --delay-directory-restore --use-compress-program unzstd
  Received 58720256 of 95363325 (61.6%), 13.9 MBs/sec
  Received 83886080 of 133844809 (62.7%), 19.7 MBs/sec
  Received 88080384 of 95363325 (92.4%), 16.7 MBs/sec
  Received 104857600 of 133844809 (78.3%), 19.7 MBs/sec
  Cache restored successfully
  Restored cache entry with key gradle-generated-gradle-jars-v1-998f666cf95b15164a53e350e73f3833 to /Users/runner/.gradle/caches/9.0.0/generated-gradle-jars/gradle-api-9.0.0.jar in 5991ms
  Received 95363325 of 95363325 (100.0%), 16.4 MBs/sec
  Cache Size: ~91 MB (95363325 B)
  /opt/homebrew/bin/gtar -xf /Users/runner/work/_temp/da0ecfe6-a11b-492e-8401-576962298a5d/cache.tzst -P -C /Users/runner/work/smithy-typescript/smithy-typescript --delay-directory-restore --use-compress-program unzstd
  Received 130023424 of 133844809 (97.1%), 20.4 MBs/sec
  Cache restored successfully
  Restored cache entry with key gradle-transforms-v1-a458b16fcb777278d9a1263ddee7b432 to /Users/runner/.gradle/caches/transforms-4/*/,/Users/runner/.gradle/caches/*/transforms/*/ in 6802ms
  Received 133844809 of 133844809 (100.0%), 20.0 MBs/sec
  Cache Size: ~128 MB (133844809 B)
  /opt/homebrew/bin/gtar -xf /Users/runner/work/_temp/13c44946-24af-4cad-81c1-8779b5aded8c/cache.tzst -P -C /Users/runner/work/smithy-typescript/smithy-typescript --delay-directory-restore --use-compress-program unzstd
  Cache restored successfully
  Restored cache entry with key gradle-dependencies-v1-811472193b97f4e4170d79af825f5277 to /Users/runner/.gradle/caches/modules-*/files-*/*/*/*/* in 7142ms
  Cache restored successfully
  Restored cache entry with key gradle-wrapper-zips-v1-579f250a568e785f3bb35fedea868447 to /Users/runner/.gradle/wrapper/dists/gradle-9.0.0-bin/d6wjpkvcgsg3oed0qlfss3wgl in 7673ms
  Cache hit for: gradle-configuration-cache-v1-ba2db532b62684695afd38b676a6ad39a6f1caa318e08ee4a51a1e604b5f8a9a
  Received 185491 of 185491 (100.0%), 0.5 MBs/sec
  Cache Size: ~0 MB (185491 B)
  /opt/homebrew/bin/gtar -xf /Users/runner/work/_temp/3093431a-908b-4956-941e-140a0c97ad27/cache.tzst -P -C /Users/runner/work/smithy-typescript/smithy-typescript --delay-directory-restore --use-compress-program unzstd
  Cache restored successfully
  Restored cache entry with key gradle-configuration-cache-v1-ba2db532b62684695afd38b676a6ad39a6f1caa318e08ee4a51a1e604b5f8a9a to /Users/runner/work/smithy-typescript/smithy-typescript/.gradle/configuration-cache in 753ms

https://github.com/smithy-lang/smithy-typescript/actions/runs/18171988915/job/51728651660?pr=1724

@trivikr
Copy link
Contributor Author

trivikr commented Oct 1, 2025

The build/jreleaser/marker.txt was ignored as it was affecting reuse of configuration cache

Before

Calculating task graph as configuration cache cannot be reused because file '../../.gradle/caches/jreleaser/jreleaser/1.20.0/marker.txt' has changed.

https://github.com/smithy-lang/smithy-typescript/actions/runs/18171988915/job/51728651660?pr=1724

First run after ignoring jreleaser marker

Calculating task graph as configuration cache cannot be reused because the set of paths ignored in file-system-check input tracking (org.gradle.configuration-cache.inputs.unsafe.ignore.file-system-checks) has changed.

https://github.com/smithy-lang/smithy-typescript/actions/runs/18172285380/job/51729664142?pr=1724

Subsequent runs

Reusing configuration cache.

Reproduced locally. Not appearing in CI, as we've disabled cache-write-only after testing it.

@trivikr trivikr merged commit 30c9c15 into main Oct 1, 2025
13 checks passed
@trivikr trivikr deleted the setup-gradle branch October 1, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants