fix(node-http-handler): undeprecate socket timeout #1745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
fix/node-http
branch
2 times, most recently
from
4101689 to
e952b32
Compare
smilkuri
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related discussion: aws/aws-sdk-js-v3#6763
The decision to deprecate socketTimeout was an error in aws/aws-sdk-js-v3#6763.
Socket timeout is a distinct concept from request timeout.
We refer to request timeout as total request time, but socket timeout is the socket's idle timeout.
For example, a long request that transfers a chunk of data every 250 milliseconds will never hit a socket timeout of 1000ms, but will eventually hit a request timeout of the same value given enough total time.