Skip to content

codegen fix for protocol test generation #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kuhe merged 2 commits into from
Dec 4, 2025
Merged

codegen fix for protocol test generation #1801

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4e24d3
codegen fix for protocol test generation
kuhe Dec 4, 2025
db43939
empty changeset
kuhe Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/submodules/cbor/CborCodec.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import type { StaticSimpleSchema, StaticStructureSchema, StringSchema, Timestamp
import { describe, expect, it } from "vitest";

import { cbor } from "./cbor";
import { CborCodec, CborShapeSerializer } from "./CborCodec";
import { tagSymbol } from "./cbor-types";
import { CborCodec, CborShapeSerializer } from "./CborCodec";

describe(CborShapeSerializer.name, () => {
const codec = new CborCodec();
Expand Down
5 changes: 3 additions & 2 deletions ...en/src/main/java/software/amazon/smithy/typescript/codegen/HttpProtocolTestGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -832,7 +832,7 @@ private void writeResponseTestSetup(OperationShape operation, HttpResponseTestCa
writer.write("$L,", isSuccess);
writer.write("$L,", testCase.getCode());
if (headers.isEmpty()) {
writer.write("undefined");
writer.write("undefined,");
} else {
writer.openBlock("{", "},", () -> {
for (Map.Entry<String, String> entry : headers.entrySet()) {
Expand All @@ -847,8 +847,9 @@ private void writeResponseTestSetup(OperationShape operation, HttpResponseTestCa
});
}
if (body != null) {
writer.write("`$L`", body);
writer.write("`$L`,", body);
}
writer.unwrite(",\n").write("");
});
});

Expand Down
Loading