[Jones3D] Adjust JonesHud constants to match OG layout a bit better #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 0.4 rc1, the inventory items are scaled a bit too small compared to the health indicator. This PR changes the default scale
JonesHud_menuItemScaleto produce item size very similar to OG. I adjustedJonesHud_menuItemTextPosYto account for the larger items to keep the text out of the 3D model. I removed the seemingly obsolete chunk of code that tried to adjust inventory height based on aspect ratio so now a predictable value is used for everybody. I changedJonesHud_invMenuDefaultZto 0.104f to stop items from sticking out above the health indicator.Screenshots:
Vanilla:
0.4 rc1
This PR: