Conversation
Newer versions of gnupg client expect to be able to send junk keygrips (unlisted) and get valid errors. Ugh.
This is for compatibility with newer gpg versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for gnupg 2.4.7, which has recently reached Debian testing.
Unfortunately gnupg has again changed the behaviour of their agent protocol in such a way that it breaks earlier versions of piv-agent. 😐
This version now works with gnupg 2.4.7 with the caveat that if you have RSA GPG keys as a fallback mechanism the pinentry dialog box will pop up every time you need to decrypt. You can click cancel and it will fall back to the Yubikey key, but it is super annoying.
Unfortunately even if we do not return the fallback keyfile keygrip in the list requested by gpg, it will still unconditionally request the non-existent key. Seems like a bug upstream.
The workaround for now is to move your keys out of the default path for piv-agent:
mv ~/.gnupg/piv-agent.secring{,bak}And then if you need to use them, move them back. Yes, it is a PITA.
Longer term, this issue has forced me to consider piv-agent's future. Here are my thoughts: #273