Skip to content

Xborder#185

Merged
smnorris merged 11 commits intomainfrom
xborder
Jan 16, 2026
Merged

Xborder#185
smnorris merged 11 commits intomainfrom
xborder

Conversation

@smnorris
Copy link
Owner

@smnorris smnorris commented Jan 16, 2026

  • add transboundary data generated by DFO
  • update various extras that depend on transboundary data
  • do not load hydrosheds/NHD data for transboundary watershed generation
  • update fwa_watershedatmeasure() to use DFO transboundary data

@smnorris smnorris merged commit 3c43bdd into main Jan 16, 2026
2 checks passed
NewGraphEnvironment added a commit to NewGraphEnvironment/fwapg that referenced this pull request Feb 17, 2026
PR smnorris#185 (Xborder) accidentally removed the exbc CTE definition from
the non-lake code path while retaining the reference in the agg CTE.
This caused cross-border watershed delineation to fail for river/canal
points upstream of international or interprovincial borders (e.g.,
Kootenay River at USA_49, Elk River at AB_120).

Restores the exact CTE that existed prior to the xborder refactor,
using ref_point geometry and measure for border crossing detection.

Fixes #1

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant