Use JSON.parse for parsing teambuilder tables #1714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This optimizes JavaScript parsing performance. V8 developers recommend applying this optimization for objects of 10 kB or larger, see <https://v8.dev/blog/cost-of-javascript-2019#json> for more details. Teambuilder tables are 3.5 MBs which is much more than 10 kB.
|
Interesting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimizes JavaScript parsing performance. V8 developers recommend applying this optimization for objects of 10 kB or larger, see https://v8.dev/blog/cost-of-javascript-2019#json for more details. Teambuilder tables are 3.5 MBs which is much more than 10 kB.
I have tested this optimization, albeit I don't know whether I have done this correctly. Over multiple attempts, with this change or not, in Firefox, this reduces parsing time from 600ms to 500ms. In Chrome, this reduces parsing time from 200ms to 100ms.
This was inspired by https://blog.guillaume-gomez.fr/articles/2021-01-22+Performance+improvement+on+front-end+generated+by+rustdoc blog post specifically which talks about optimization of rustdoc frontend code, and that was one of optimizations that was done (rustdoc PR: rust-lang/rust#71250).