Skip to content

Fix newly added clippy warnings #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 6, 2025
Merged

Fix newly added clippy warnings #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a2bb61
Fix clippy::uninlined_format_args warning
taiki-e Jul 6, 2025
ebc479c
Ignore clippy::unused_unit lint
taiki-e Jul 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions benches/executor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ fn running_benches(c: &mut Criterion) {
for (group_name, multithread) in [("single_thread", false), ("multi_thread", true)].iter() {
let mut group = c.benchmark_group(group_name.to_string());

group.bench_function(format!("{}::spawn_one", prefix), |b| {
group.bench_function(format!("{prefix}::spawn_one"), |b| {
if with_static {
run_static(
|| {
Expand Down Expand Up @@ -98,7 +98,7 @@ fn running_benches(c: &mut Criterion) {
});
}

group.bench_function(format!("{}::spawn_many_local", prefix), |b| {
group.bench_function(format!("{prefix}::spawn_many_local"), |b| {
if with_static {
run_static(
|| {
Expand Down Expand Up @@ -136,7 +136,7 @@ fn running_benches(c: &mut Criterion) {
}
});

group.bench_function(format!("{}::spawn_recursively", prefix), |b| {
group.bench_function(format!("{prefix}::spawn_recursively"), |b| {
#[allow(clippy::manual_async_fn)]
fn go(i: usize) -> impl Future<Output = ()> + Send + 'static {
async move {
Expand Down Expand Up @@ -201,7 +201,7 @@ fn running_benches(c: &mut Criterion) {
}
});

group.bench_function(format!("{}::yield_now", prefix), |b| {
group.bench_function(format!("{prefix}::yield_now"), |b| {
if with_static {
run_static(
|| {
Expand Down Expand Up @@ -247,7 +247,7 @@ fn running_benches(c: &mut Criterion) {
}
});

group.bench_function(format!("{}::channels", prefix), |b| {
group.bench_function(format!("{prefix}::channels"), |b| {
if with_static {
run_static(
|| {
Expand Down Expand Up @@ -325,7 +325,7 @@ fn running_benches(c: &mut Criterion) {
}
});

group.bench_function(format!("{}::web_server", prefix), |b| {
group.bench_function(format!("{prefix}::web_server"), |b| {
if with_static {
run_static(
|| {
Expand Down
4 changes: 2 additions & 2 deletions examples/priority.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ fn main() {

// Spawn a task with this priority.
tasks.push(EX.spawn(priority, async move {
println!("{:?}", priority);
println!("{priority:?}");
future::yield_now().await;
println!("{:?}", priority);
println!("{priority:?}");
}));
}

Expand Down
1 change: 1 addition & 0 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
html_logo_url = "https://raw.githubusercontent.com/smol-rs/smol/master/assets/images/logo_fullsize_transparent.png"
)]
#![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
#![allow(clippy::unused_unit)] // false positive fixed in Rust 1.89

use std::fmt;
use std::marker::PhantomData;
Expand Down