Update criterion to 0.6, Update rust-version to 1.66, fix warnings.#227
Closed
dcampbell24 wants to merge 1 commit intosmol-rs:masterfrom
dcampbell24:update-criterion
Closed
Update criterion to 0.6, Update rust-version to 1.66, fix warnings.#227dcampbell24 wants to merge 1 commit intosmol-rs:masterfrom dcampbell24:update-criterion
dcampbell24 wants to merge 1 commit intosmol-rs:masterfrom
dcampbell24:update-criterion
Conversation
Contributor
Author
|
In order to use |
Collaborator
|
Thanks for the PR, but we have no interested on bumping MSRV for dev-deps (this is why we skipped criterion 0.5). |
Contributor
Author
|
Okay, should we leave this open in case some other feature warrants bumping the MSRV? |
Collaborator
|
Yeah, we can keep this open. Our next MSRV bump will happen this summer or this fall to align with the new Debian stable release. |
Collaborator
|
Handled by #226 & #234. (When I actually tried it out, I found that MSRV bump wasn't necessary anywhere. I think you misunderstood Clippy's false positive as being genuine.) I'm going to close this PR, but thanks anyway for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.