Make tracing optional & fix CI failure & update CI config #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
error: variables can be used directly in the `format!` string
--> examples/timeout.rs:75:9
|
75 | println!("Stdout:\n{}", stdout);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-D clippy::uninlined-format-args` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
75 - println!("Stdout:\n{}", stdout);
75 + println!("Stdout:\n{stdout}");
|
error: variables can be used directly in the `format!` string
--> examples/timeout.rs:76:9
|
76 | println!("Stderr:\n{}", stderr);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
76 - println!("Stderr:\n{}", stderr);
76 + println!("Stderr:\n{stderr}");
|
error: could not compile `async-process` (example "timeout") due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
error: variables can be used directly in the `format!` string
--> tests/std.rs:80:23
|
80 | result => panic!("not terminated by signal 9 (instead, {:?})", result),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-D clippy::uninlined-format-args` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
80 - result => panic!("not terminated by signal 9 (instead, {:?})", result),
80 + result => panic!("not terminated by signal 9 (instead, {result:?})"),
|
error: variables can be used directly in the `format!` string
--> tests/std.rs:335:9
|
335 | / assert!(
336 | | output.contains("RUN_TEST_NEW_ENV=123"),
337 | | "didn't find RUN_TEST_NEW_ENV inside of:\n\n{}",
338 | | output
339 | | );
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
error: variables can be used directly in the `format!` string
--> tests/std.rs:353:9
|
353 | / assert!(
354 | | output.contains("RUN_TEST_NEW_ENV=123"),
355 | | "didn't find RUN_TEST_NEW_ENV inside of:\n\n{}",
356 | | output
357 | | );
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
error: variables can be used directly in the `format!` string
--> tests/std.rs:375:9
|
375 | / assert!(
376 | | output.contains("RUN_TEST_NEW_ENV1=123"),
377 | | "didn't find RUN_TEST_NEW_ENV1 inside of:\n\n{}",
378 | | output
379 | | );
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
error: variables can be used directly in the `format!` string
--> tests/std.rs:380:9
|
380 | / assert!(
381 | | output.contains("RUN_TEST_NEW_ENV2=456"),
382 | | "didn't find RUN_TEST_NEW_ENV2 inside of:\n\n{}",
383 | | output
384 | | );
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
```
```
error[E0432]: unresolved import `async_io::os::windows`
--> src\reaper\wait.rs:188:27
|
188 | use async_io::os::windows::Waitable;
| ^^^^^^^ could not find `windows` in `os`
```
```
error: you seem to be trying to use `match` to destructure a single infallible pattern. Consider using `let`
--> src/reaper/wait.rs:71:13
|
71 | / let inner = match &mut child.inner {
72 | | super::ChildGuard::Wait(inner) => inner,
73 | | #[cfg(not(windows))]
74 | | _ => unreachable!(),
75 | | };
| |______________^ help: try: `let super::ChildGuard::Wait(inner) = &mut child.inner;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#infallible_destructuring_match
= note: `-D clippy::infallible-destructuring-match` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::infallible_destructuring_match)]`
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.