Bump MSRV to 1.47, reduce size of sys::Events #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
commented
Aug 21, 2022
| @@ -221,7 +221,7 @@ impl Events { | |||
| data: 0, | |||
| udata: 0 as _, | |||
| }; | |||
| let list = vec![ev; 1000].into_boxed_slice(); | |||
There was a problem hiding this comment.
I'm not sure why the old code used 1000 instead of 1024.
There was a problem hiding this comment.
It would be a mis-optimization, if I had to guess.
| @@ -289,7 +289,7 @@ impl Events { | |||
| /// Creates an empty list. | |||
| pub fn new() -> Events { | |||
| let ev = libc::epoll_event { events: 0, u64: 0 }; | |||
| let list = vec![ev; 1000].into_boxed_slice(); | |||
| let list = Box::new([ev; 1024]); | |||
There was a problem hiding this comment.
I didn't do it on this patch, but calling alloc_zeroed via unsafe code is probably best from a point of view of performance.
https://godbolt.org/z/T1e8ETv61 https://godbolt.org/z/hcss6hEaT https://godbolt.org/z/fG9ddPsdq
taiki-e
changed the title
zeenix
approved these changes
Aug 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libcplans to raise their MSRV to 1.47 (rust-lang/libc#2845), and some crates of smol-rs also require 1.47 since async-task 4.3.0 (smol-rs/async-task#30). It seems to be a reasonable time to do #19.This also reduces the size of
sys::Events(closes #19).