Skip to content

Conversation

KingCol13
Copy link
Contributor

Fixes #1068

@KingCol13 KingCol13 marked this pull request as draft July 2, 2025 23:54
@KingCol13 KingCol13 force-pushed the tcp-raw-socket-no-reset branch from 1108dd5 to 4fb8a24 Compare July 4, 2025 23:13
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.33%. Comparing base (ac32e64) to head (421940b).

Files with missing lines Patch % Lines
src/iface/interface/ipv6.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1069   +/-   ##
=======================================
  Coverage   80.33%   80.33%           
=======================================
  Files          81       81           
  Lines       24339    24341    +2     
=======================================
+ Hits        19552    19555    +3     
+ Misses       4787     4786    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KingCol13 KingCol13 marked this pull request as ready for review July 4, 2025 23:16
@KingCol13 KingCol13 force-pushed the tcp-raw-socket-no-reset branch from 4fb8a24 to 421940b Compare August 28, 2025 18:06
@KingCol13
Copy link
Contributor Author

Sorry for the initial false start, this now matches process_udp in src/iface/interface/udp.rs behaviour when a raw socket has handled the packet. The coverage change seems to be just because rustfmt added a new line. I think this is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Do not reset TCP connections when using a RawSocket
1 participant