feat: convert Enpoint into SocketAddr#1124
Merged
Dirbaio merged 1 commit intosmoltcp-rs:mainfrom Feb 27, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1124 +/- ##
==========================================
- Coverage 81.28% 81.27% -0.01%
==========================================
Files 81 81
Lines 24838 24841 +3
==========================================
Hits 20189 20189
- Misses 4649 4652 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
smoltcp::wire::Endpointalready supports conversion fromcore::net::SocketAddr(and v4/v6 variants), but there is no reverse conversion back toSocketAddr.In real integrations, this causes small but repeated friction when interacting with APIs or logging paths that use standard Rust socket address types:
core/std-based codeSocketAddr -> Endpointexists, reverse does not)Proposed Solution
A direct conversion from
Endpointtocore::net::SocketAddrshould be added. This makes conversion support symmetrical and removes boilerplate when interoperating with the Rust networking ecosystem.API Design