Fix test failures: list equality and library import priority#845
Merged
Fix test failures: list equality and library import priority#845
Conversation
- Add missing ValNil/ValCons cross-comparison cases in runBinOpEquals, fixing pattern matching on non-empty lists against EMPTY - Prioritize Cabal data-dir over XDG for library resolution, preventing stale installed libraries from shadowing source tree versions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValNil/ValConscross-comparison cases inrunBinOpEquals. Pattern matchingWHEN EMPTYagainst a non-empty list was throwing "equality on unsupported types" instead of returningFalse. Fixeslegal-persons-tests.l4.~/.local/share/jl4/libraries/). Stale XDG-installed libraries were shadowing current source tree versions during development, causing 7 test failures (6 excel-date + ceo-performance-award).Test plan
cabal test all— 847 examples, 0 failures across all 6 test suites🤖 Generated with Claude Code