Fix compile error with GCC 15 (-std=c23)#12
Closed
ueno wants to merge 2 commits intosmuellerDD:masterfrom
Closed
Conversation
In C23, "true", "false", and "bool" are reserved keywords and cannot be redefined: https://en.wikipedia.org/wiki/C23_(C_standard_revision)#Keywords Signed-off-by: Daiki Ueno <dueno@redhat.com>
smuellerDD
reviewed
Jan 22, 2025
Given <stdint.h> is already there, it wouldn't hurt to have <stdbool.h> as well, as both headers are in the C99 standard. Signed-off-by: Daiki Ueno <dueno@redhat.com>
Owner
|
Applied, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling on Fedora rawhide, it fails with:
The first commit should fix it, though the second commit is just a cosmetics.