x86: embed .note.gnu.property for Intel CET in assembly files#16
Closed
ueno wants to merge 1 commit intosmuellerDD:masterfrom
Closed
x86: embed .note.gnu.property for Intel CET in assembly files#16ueno wants to merge 1 commit intosmuellerDD:masterfrom
ueno wants to merge 1 commit intosmuellerDD:masterfrom
Conversation
ueno
force-pushed
the
wip/intel-cet
branch
3 times, most recently
from
e91dd03 to
e210d06
Compare
Instead of generating the note section with a linker option, this embeds it in each .S file through a preprocessor macro. The main motivation behind this is to simplify the build process when a shared library is statically linking to leancrypto. As a bonus, this mechanism could be used to support PACBTI on AArch64 in a future extension. Signed-off-by: Daiki Ueno <dueno@redhat.com>
Owner
|
Am Donnerstag, 13. Februar 2025, 00:56:31 Mitteleuropäische Normalzeit schrieb
Daiki Ueno:
Hi Daiki,
Instead of generating the note section with a linker option, this embeds it
in each .S file through a preprocessor macro. The main motivation behind
this is to simplify the build process when a shared library is statically
linking to leancrypto. As a bonus, this mechanism could be used to support
PACBTI on AArch64 in a future extension. You can view, comment on, or merge
this pull request online at:
Thanks a lot for the patch. I have applied it with a small editorial change: I
used LC_ASM_END to avoid polluting the namespace.
You may wonder why I did not do that with the SYM_* / RET macros: this is due
to the fact that the Linux kernel defines them too. And thus I simply reuse
its macros.
And, I had to hand-apply it because somehow git did not like it - thus you are
not displayed as the author, sorry.
Ciao
Stephan
|
Owner
|
Applied, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of generating the note section with a linker option, this embeds it in each .S file through a preprocessor macro. The main motivation behind this is to simplify the build process when a shared library is statically linking to leancrypto. As a bonus, this mechanism could be used to support PACBTI on AArch64 in a future extension.