Open
Conversation
resolution quarter_hourly
Owner
|
Thanks, I am on a vacation now, and won't be able to properly review this for a week or so. However if it is so that the API is no longer working because of the change in interval, please let me know and I can merge now and test later. |
Contributor
Author
|
Hi snakehand, Since you are charged by the prices that are changed every 15 minutes, the prices in a hourly resolution might not be 100.0% accurate anymore. However, the api still delivers the prices in a hourly resolution with the graphql-code used in your lib, so programs, which rely on tibber in your main branch, will still be working (so was mine). So there is no need to hurry ;) Enjoy your vacation and travel safely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I added the new resolution of 15 minutes to the code. Although this seems to be working on my system, I recommend to test it.
Best