Skip to content

Conversation

@cmeesters
Copy link
Collaborator

@cmeesters cmeesters commented Dec 12, 2025

Summary by CodeRabbit

  • Chores
    • Updated minimum version requirements for core project dependencies to ensure compatibility and system stability.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 12, 2025

Walkthrough

Updates version constraints in the conda environment specification for two packages: ncbi-datasets-cli now requires a minimum version of 18.12.0, and unzip requires a minimum version of 6.0.0, replacing previous exact-version pinning.

Changes

Cohort / File(s) Change Summary
Dependency Version Constraints
workflow/envs/reference.yml
Updates ncbi-datasets-cli minimum version to >=18.12.0 and unzip minimum version to >=6.0.0, replacing exact-version specifications with flexible version requirements

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single configuration file with straightforward version constraint updates
  • No logic changes or functional modifications

Poem

🐰 Versions hop and bounds do change,
From fixed to flexible, a lighter range!
Two dependencies now breathe with grace,
Minimum versions win the race! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating version constraints for ncbi-datasets-cli and unzip in the workflow environment file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/update_dataset_env

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
workflow/envs/reference.yml (1)

4-5: Consider adding an upper bound (or a lockfile) to keep the env reproducible.

Both ncbi-datasets-cli>=18.12.0 and unzip>=6.0.0 are valid on conda-forge. However, using only lower bounds (>=) can introduce silent upgrades that may break workflows over time. Given the repo's apparent preference for stability (as seen in flair.yml), consider constraining with upper bounds (e.g., ncbi-datasets-cli>=18.12.0,<19, unzip>=6.0.0,<7) or adopting a conda-lock file to ensure reproducibility across environments and CI runs.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 16012bb and a82457e.

📒 Files selected for processing (1)
  • workflow/envs/reference.yml (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: cmeesters
Repo: snakemake-workflows/rna-longseq-de-isoform PR: 115
File: workflow/envs/flair.yml:5-5
Timestamp: 2025-08-01T14:33:59.639Z
Learning: In the flair conda environment (workflow/envs/flair.yml), the version is intentionally hard-pinned to flair=2.0.0 because upstream versions are considered experimental and should not be used for stability reasons.
📚 Learning: 2025-08-01T14:33:59.639Z
Learnt from: cmeesters
Repo: snakemake-workflows/rna-longseq-de-isoform PR: 115
File: workflow/envs/flair.yml:5-5
Timestamp: 2025-08-01T14:33:59.639Z
Learning: In the flair conda environment (workflow/envs/flair.yml), the version is intentionally hard-pinned to flair=2.0.0 because upstream versions are considered experimental and should not be used for stability reasons.

Applied to files:

  • workflow/envs/reference.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Testing

@cmeesters cmeesters requested a review from yeising December 12, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants